karolyi/py3-validate-email
3
1
Fork 0
Code Issues 1 Pull requests Projects Releases Wiki Activity

Introduce distinct exception classes and logging #8

Merged
reinhard-mueller merged 3 commits from master into master 2020-04-10 13:24:54 +02:00
Conversation 3 Commits 3 Files changed 10 +192 -70
reinhard-mueller commented 2020-04-09 00:00:40 +02:00 (Migrated from github.com)
Copy link

Please have a look and tell me if you would like to see something changed.

Please have a look and tell me if you would like to see something changed.
karolyi commented 2020-04-10 13:25:09 +02:00 (Migrated from github.com)
Copy link

Thank you!

Thank you!
reinhard-mueller commented 2020-04-10 16:23:26 +02:00 (Migrated from github.com)
Copy link

Oops @karolyi I'm sorry for the wrong docstrings for the exception classes. That's the downside of copy&paste...

Oops @karolyi I'm sorry for the wrong docstrings for the exception classes. That's the downside of copy&paste...
karolyi commented 2020-04-10 16:48:08 +02:00 (Migrated from github.com)
Copy link

No worries man. I corrected them and made another couple cosmetic changes too. I'm working on the updater part and then a release is due.

No worries man. I corrected them and made another couple cosmetic changes too. I'm working on the updater part and then a release is due.
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
stale

   
wontfix

This will not be worked on

No labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
stale
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: karolyi/py3-validate-email#8
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?