Optional Blacklist

bensnyde commented

2020-09-23 23:50:34 +02:00

(Migrated from github.com)

py3-validate-email cannot be pip installed without outbound network access since the setup.py fetches the domain blacklist file.

karolyi commented

2020-09-23 23:53:28 +02:00

(Migrated from github.com)

yep, and pip fetches the package from the pypi repo.

bensnyde commented

2020-09-29 03:32:08 +02:00

(Migrated from github.com)

Our enterprise uses Jfrog Artifactory to "securely" mirror packages from pypi. Our enterprise applications are allowed to pull from our internal Artifactory, but cannot breach the firewall to pull down the blocklist from Github.

Would you be willing to use a skeleton blacklist file instead of forcing the download during setup?

Our enterprise uses Jfrog Artifactory to "securely" mirror packages from pypi. Our enterprise applications are allowed to pull from our internal Artifactory, but cannot breach the firewall to pull down the blocklist from Github. Would you be willing to use a skeleton blacklist file instead of forcing the download during setup?

karolyi commented

2020-10-03 14:11:40 +02:00

(Migrated from github.com)

Can you post the complete error message you're getting when it tries to fetch the blacklist?

karolyi commented

2020-10-11 14:11:14 +02:00

(Migrated from github.com)

Please try to post it with the version 0.2.10 which is out now with STARTTLS support.

Please try to post it with the version `0.2.10` which is out now with STARTTLS support.

bensnyde commented

2020-10-11 16:37:06 +02:00

(Migrated from github.com)

I appreciate the update, but the problem is not with the SSL handshake.
Enterprise security frowns upon allowing an application to have egress
traffic, especially to a site like Github.

Since py3-validate-email forces a download of the blacklist from Github
during setup, we cannot use it, or any library that depends on it.

This is a request for a redesign wherein downloading the blacklist is
optional.

Perhaps instead of use_blacklist=True, you could accept a blacklist as a
parameter? Not only would this allow for greater configuration, but you
could set a default that would install/update your Github blacklist?

On Sun, Oct 11, 2020 at 7:11 AM László Károlyi notifications@github.com
wrote:

Please try to post it with the version 0.2.10 which is out now with
STARTTLS support.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/karolyi/py3-validate-email/issues/29#issuecomment-706695572,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHXFUTNRUCXWQXQD4BWUVDSKGOG5ANCNFSM4RXRQOIQ
.

I appreciate the update, but the problem is not with the SSL handshake. Enterprise security frowns upon allowing an application to have egress traffic, especially to a site like Github. Since py3-validate-email forces a download of the blacklist from Github during setup, we cannot use it, or any library that depends on it. This is a request for a redesign wherein downloading the blacklist is optional. Perhaps instead of use_blacklist=True, you could accept a blacklist as a parameter? Not only would this allow for greater configuration, but you could set a default that would install/update your Github blacklist? On Sun, Oct 11, 2020 at 7:11 AM László Károlyi <notifications@github.com> wrote: > Please try to post it with the version 0.2.10 which is out now with > STARTTLS support. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/karolyi/py3-validate-email/issues/29#issuecomment-706695572>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAHXFUTNRUCXWQXQD4BWUVDSKGOG5ANCNFSM4RXRQOIQ> > . >

karolyi commented

2020-10-11 17:24:00 +02:00

(Migrated from github.com)

Hey,

I knew the problem is not STARTTLS. I just asked you to post a detailed error log for me to see a traceback where the underlying updater throws an exception.

The generic idea is useful, I can of course change the source to make the downloading of the blacklist optional. But first, in order to fix it, I need to be able to reproduce the problem.

Secondly, this project is opensource, and so PRs are welcome. I can do it too, but right now I have other priorities: projects that are actually bringing some income. Right now I'm only available to this project in my most valued free time.

Hey, I knew the problem is not STARTTLS. I just asked you to post a detailed error log for me to see a traceback where the underlying updater throws an exception. The generic idea is useful, I can of course change the source to make the downloading of the blacklist optional. But first, in order to fix it, I need to be able to reproduce the problem. Secondly, this project is opensource, and so PRs are welcome. I can do it too, but right now I have other priorities: projects that are actually bringing some income. Right now I'm only available to this project in my most valued free time.

stale[bot] commented

2020-10-25 17:47:17 +01:00

(Migrated from github.com)

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Optional Blacklist #29